Conversation
This was referenced Sep 30, 2026
A chosen summary-maintenance lifecycle did not reach the DAG: timing was fixed by realization strategies. SummaryMaintenanceLifecyclePlan:: execution_timed_dag assigns every node's timing from the selection: retained (non-Ephemeral) states and their inputs at ingestion time, everything else at query time. States without a selected lifecycle, and maintained populations that lifecycle enumeration does not cover, are refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replace the open question about placement ownership with the agreed four-layer contract: logical Post-ASAP decides what to compute, the chosen lifecycle decides timing, physical compilation partitions by timing, and the backend prices lifecycle choices including store cost. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
added a commit
that referenced
this pull request
Sep 30, 2026
Replace the largest-non-ASAP-subtree fragment export with one Relational node per operator, so physical compilation corresponds node by node. Name the timing source as physical design (summary materialization) and point the open LifecycleAssignment question at SummaryMaintenanceLifecyclePlan (#482). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
feat/lifecycle-candidates
branch
from
September 30, 2026 18:27
4bb8c86 to
07244ea
Compare
zzylol
force-pushed
the
feat/lifecycle-timing
branch
from
September 30, 2026 18:27
0747971 to
3b281da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #476.
Rebuilt into the linear stack on main. Conflict resolutions are recorded in the messages of: "test: carry a chosen lifecycle through timing to physical compilation".
Why
Agreed layering: the summary maintenance lifecycle layer sits between logical
Post-ASAP and physical compilation, and a chosen lifecycle assignment is what
decides each node's execution timing (precompute vs query time). Today timing is
hard-coded by logical strategies when they build candidates, and a lifecycle
choice (e.g.
EphemeralvsContinuouslyMaintained) never reaches the DAG, soit cannot change what runs in precompute.
What
SummaryMaintenanceLifecyclePlan::execution_timed_dag() -> Result<PostAsapDag, SummaryMaintenanceTimingError>applies the plan's lifecycle choices to every node via
with_execution_phases:ContinuouslyMaintained,Shared,Prepared) and everynode feeding it run at ingestion time;
Ephemeralstates run at query time; thedeployment supplies their raw data as a query-time source;
Ephemeralstate feeding a retained state runs at ingestion time (querytime may not feed ingestion time);
does not list, is refused.
by the four-layer contract (logical → lifecycle → physical → deployment).
Hard-coded timing in logical strategies is left in place for a follow-up; with
Planner's default selection the timed DAG equals today's for the PromQL fixtures.
Before this PR
After this PR
Validation
Unit tests for every lifecycle kind, a shared state with two readouts, an
Ephemeralstate feeding a retained state, unselected and unplanned states.End to end (
summary_maintenance_lifecycle_e2e): Planner's selection reproducestoday's timing for
quantile_over_time,quantileandsum by(job)(rate); aContinuouschoice puts exactly the state in precompute whileEphemeralleavesprecompute empty, and both return the same p99.
cargo fmt --checkandcargo clippy --workspace --all-targets -- -D warningspass;asap-aware-mapping478 passed; workspace passes except the pre-existing
devtools dag_export::workload_node_ids_make_smaller_topk_reuse_explicit.Follow-ups
replacement.rs,exact_composition.rs,maintained_population.rs, and move feat: expose physical-ready logical candidates in Planner selection #472's grouped Rate→Sum placement pair tothe lifecycle layer.
test derives it today).
🤖 Generated with Claude Code